Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean localization #593

Merged
merged 5 commits into from
Sep 2, 2018
Merged

Update Korean localization #593

merged 5 commits into from
Sep 2, 2018

Conversation

Canorus
Copy link
Contributor

@Canorus Canorus commented Sep 2, 2018

  • Fix typo
  • Change 'redo' translation to what majority agreed as the most natural one
  • Add notification preference translation
  • Add time format translation

@Canorus
Copy link
Contributor Author

Canorus commented Sep 2, 2018

oh btw you might want to update all other translations as well. They didn't have time format either.

@h3poteto
Copy link
Owner

h3poteto commented Sep 2, 2018

Yes, I hope that each language specialists will translate it.

@Canorus
Copy link
Contributor Author

Canorus commented Sep 2, 2018

well wish there's some way to send notification, desirably automatically when translation file is changed, to whoever contributed in translation. I didn't even know there was new items to translate…

@Canorus
Copy link
Contributor Author

Canorus commented Sep 2, 2018

I didn't have to close and pull a new request thanks to github, and github gracefully resolved the conversation as well.

@h3poteto
Copy link
Owner

h3poteto commented Sep 2, 2018

No problem, thank you for your translation and fix.

@h3poteto h3poteto merged commit 8c91dd0 into h3poteto:master Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants