Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deutsch for close confirm modal #511

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Fix Deutsch for close confirm modal #511

merged 1 commit into from
Aug 18, 2018

Conversation

h3poteto
Copy link
Owner

I added close confirm modal, and some words don't translate to German.

h3poteto
h3poteto commented Aug 17, 2018
View reviewed changes
src/config/locales/de/translation.json
"toot": "Toot",
"close_confirm": "Möchtest du wirklich schließen?",
"close_confirm_ok": "Schließen",
"close_confirm_cancel": "Abbrechen"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinzv Is it correct? I don't know German.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h3poteto Yes, looking good.

@h3poteto h3poteto merged commit e4026c0 into master Aug 18, 2018
@h3poteto h3poteto deleted the confirm/german branch August 18, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzv vinzv vinzv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h3poteto @vinzv