-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Allow user view toot detail at sidebar #206
Conversation
|
||
li{ | ||
padding-bottom: 0.5em; | ||
border-bottom: 1px solid #ddd; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want the cursor to be a pointer when a mouse points over this object. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so too. I added the toot menu but forgot to change the cursor to pointer, sorry : (
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit added &:hover{ cursor: pointer; } to toot menu item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
} | ||
} | ||
|
||
export default TootDetail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
}) | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
commit('updateDescendants', data.descendants) | ||
resolve(res) | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
commit('updateAncestors', data.ancestors) | ||
commit('updateDescendants', data.descendants) | ||
resolve(res) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
if (err) return reject(err) | ||
commit('updateAncestors', data.ancestors) | ||
commit('updateDescendants', data.descendants) | ||
resolve(res) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
return new Promise((resolve, reject) => { | ||
const client = new Mastodon( | ||
{ | ||
access_token: rootState.TimelineSpace.account.accessToken, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier 'access_token' is not in camel case.
}, | ||
fetchToot ({ state, commit, rootState }, message) { | ||
return new Promise((resolve, reject) => { | ||
const client = new Mastodon( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
commit('changeToot', message) | ||
}, | ||
fetchToot ({ state, commit, rootState }, message) { | ||
return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'Promise' is not defined.
changeToot ({ commit, dispatch }, message) { | ||
commit('changeToot', message) | ||
}, | ||
fetchToot ({ state, commit, rootState }, message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
}, | ||
actions: { | ||
changeToot ({ commit, dispatch }, message) { | ||
commit('changeToot', message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
|
border-bottom: 1px solid #ddd; | ||
|
||
&:hover{ | ||
cursor: pointer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see Σ(;゚д゚)
It's look like so interesting.
Thank you for your contribution! |
Fix bug of #205 .