Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow user view toot detail at sidebar #206

Merged
merged 12 commits into from
Apr 12, 2018
Merged

Fix: Allow user view toot detail at sidebar #206

merged 12 commits into from
Apr 12, 2018

Conversation

falconshark
Copy link

Fix bug of #205 .

@falconshark falconshark mentioned this pull request Apr 11, 2018

li{
padding-bottom: 0.5em;
border-bottom: 1px solid #ddd;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the cursor to be a pointer when a mouse points over this object. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so too. I added the toot menu but forgot to change the cursor to pointer, sorry : (

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit added &:hover{ cursor: pointer; } to toot menu item.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

}
}

export default TootDetail

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

})
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

commit('updateDescendants', data.descendants)
resolve(res)
})
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

commit('updateAncestors', data.ancestors)
commit('updateDescendants', data.descendants)
resolve(res)
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

if (err) return reject(err)
commit('updateAncestors', data.ancestors)
commit('updateDescendants', data.descendants)
resolve(res)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

return new Promise((resolve, reject) => {
const client = new Mastodon(
{
access_token: rootState.TimelineSpace.account.accessToken,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier 'access_token' is not in camel case.

},
fetchToot ({ state, commit, rootState }, message) {
return new Promise((resolve, reject) => {
const client = new Mastodon(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

commit('changeToot', message)
},
fetchToot ({ state, commit, rootState }, message) {
return new Promise((resolve, reject) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'Promise' is not defined.

changeToot ({ commit, dispatch }, message) {
commit('changeToot', message)
},
fetchToot ({ state, commit, rootState }, message) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

},
actions: {
changeToot ({ commit, dispatch }, message) {
commit('changeToot', message)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@h3poteto
Copy link
Owner

houndci-bot is just I tried, so you can ignore these comments. I also feel that I have to adjust houndci.

border-bottom: 1px solid #ddd;

&:hover{
cursor: pointer;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Σ(;゚д゚)
It's look like so interesting.

@h3poteto h3poteto merged commit 00ed3f4 into h3poteto:master Apr 12, 2018
@h3poteto
Copy link
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants