GoToSocial: fix getAccountFollowing failing because the final page omits a link header.
#2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omits a `link` header. urlToAccounts appears to assume that the link header will continue to be present, but in my testing it seems to go away on the last page. parseLinkHeader throws if you pass an `undefined` header into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlToAccounts()appears to assume that thelinkheader will continue to be present, but in my testing when I callgetAccountFollowing(), the final page of accounts is completely missing thelinkheader.parseLinkHeader()throws if you pass anundefinedheader into it, so without this fix I'm effectively unable to usegetAccountFollowing()on my GoToSocial instance.