Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs with preferred way of displaying documents #2291 #2311

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

marek-mihok
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Closes #2291

@marek-mihok
Copy link
Contributor Author

For some reason PDF in /docs/widgets/form/frame/#with-document section is not rendered:

image

The path seems to be correct. @mturoci could you please check where could be the problem?

@marek-mihok marek-mihok marked this pull request as ready for review April 8, 2024 10:15
@mturoci
Copy link
Collaborator

mturoci commented Apr 12, 2024

@marek-mihok the problem is in Playwright - headless mode does not render pdfs for some reason, but headed does. See #2314.

@mturoci mturoci merged commit 293c837 into main Apr 12, 2024
2 checks passed
@mturoci mturoci deleted the feat/issue-2291 branch April 12, 2024 11:34
@mturoci mturoci mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF does not render in expander in Safari
2 participants