Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] testing and cleanup #831

Merged
merged 13 commits into from
Aug 18, 2024
Merged

[Chore] testing and cleanup #831

merged 13 commits into from
Aug 18, 2024

Conversation

pascal-pfeiffer
Copy link
Collaborator

  • removes unused q.client["experiment/list/mode"]
  • removes unused predictions arg in get_experiment_table
  • rename check_environment to check_metric
  • import from transformers.integrations instead of deprecated
  • add a few unit tests

psinger
psinger approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@psinger psinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the error msg tests

@pascal-pfeiffer pascal-pfeiffer merged commit 3d4190f into main Aug 18, 2024
4 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the pp/testing_and_cleanup branch August 18, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psinger psinger psinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascal-pfeiffer @psinger