Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causal Regression Modeling #788

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Causal Regression Modeling #788

merged 5 commits into from
Jul 30, 2024

Conversation

psinger
Copy link
Collaborator

@psinger psinger commented Jul 29, 2024

Adds new problem type causal regression modeling

Closes #495

Some code is duplicated, but decided to split it into two problem types.

Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Can you look at the DS import quickly? I think it fails with the same issue that also fails in the test cases.

image

Else, code looks good to me! We probably want to extend docs, too, but that can be done in a subsequent PR.

@psinger
Copy link
Collaborator Author

psinger commented Jul 30, 2024

That's weird, import works fine for me locally, will investigate.

For docs, where would we need to add it?

@psinger
Copy link
Collaborator Author

psinger commented Jul 30, 2024

@pascal-pfeiffer ok should be fixed, wasnt pushed due to gitignore :)

Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working quite nicely, thank you!

Indeed, more documentation changes are probably not needed. Some suggestions/comments/questions in the code below.

Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! lgtm

@psinger psinger merged commit 2e095cd into main Jul 30, 2024
4 checks passed
@psinger psinger deleted the psi/regression branch July 30, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Causal Regression Modeling
2 participants