-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Causal Regression Modeling #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird, import works fine for me locally, will investigate. For docs, where would we need to add it? |
@pascal-pfeiffer ok should be fixed, wasnt pushed due to gitignore :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working quite nicely, thank you!
Indeed, more documentation changes are probably not needed. Some suggestions/comments/questions in the code below.
llm_studio/python_configs/text_causal_regression_modeling_config.py
Outdated
Show resolved
Hide resolved
llm_studio/python_configs/text_causal_regression_modeling_config.py
Outdated
Show resolved
Hide resolved
llm_studio/python_configs/text_causal_regression_modeling_config.py
Outdated
Show resolved
Hide resolved
llm_studio/python_configs/text_causal_regression_modeling_config.py
Outdated
Show resolved
Hide resolved
llm_studio/python_configs/text_causal_regression_modeling_config.py
Outdated
Show resolved
Hide resolved
llm_studio/src/metrics/text_causal_regression_modeling_metrics.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! lgtm
Adds new problem type causal regression modeling
Closes #495
Some code is duplicated, but decided to split it into two problem types.