Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LLM Backbone Explanations #766

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Improve LLM Backbone Explanations #766

merged 5 commits into from
Jul 1, 2024

Conversation

mtanco
Copy link
Contributor

@mtanco mtanco commented Jun 28, 2024

Addresses #765 by updating the documentation and tool tip explaining how the LLM Backbone parameter works in the UI.

@mtanco mtanco requested a review from sherenem as a code owner June 28, 2024 20:26
@pascal-pfeiffer pascal-pfeiffer linked an issue Jun 28, 2024 that may be closed by this pull request
[DOC] Document Adding New Backbone #765
Closed
pascal-pfeiffer
pascal-pfeiffer approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mtanco !
Two nitpicks in the comments

documentation/docs/tooltips/experiments/_llm-backbone.mdx Outdated Show resolved Hide resolved
documentation/docs/guide/experiments/create-an-experiment.md Outdated Show resolved Hide resolved
sherenem
sherenem approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@sherenem sherenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mtanco !

@pascal-pfeiffer pascal-pfeiffer merged commit 0a42e8e into main Jul 1, 2024
4 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the MT/765 branch July 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherenem sherenem sherenem approved these changes

@pascal-pfeiffer pascal-pfeiffer pascal-pfeiffer approved these changes

@psinger psinger Awaiting requested review from psinger psinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Document Adding New Backbone
3 participants
@mtanco @pascal-pfeiffer @sherenem