-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPO & SimPO Loss #749
CPO & SimPO Loss #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the integration @psinger !
It seems to work nicely, though default values give bad results.
We might want to consider not to rename the Loss functions to avoid issues when starting from older experiments.
Also, there is a minor issue with the calculation of the number of experiments being started in grid search.
Bad in what way? It is based on best experiments I got for them, but it might be more sensitive depending on what model / data one uses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @psinger , lgtm!
This PR implements new CPOLoss and SimPOLoss
Please review after #753
Closes #732