Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dataset import #717

Merged
merged 9 commits into from
May 24, 2024
Merged

Improve dataset import #717

merged 9 commits into from
May 24, 2024

Conversation

pascal-pfeiffer
Copy link
Collaborator

import_dataset-2024-05-22_13.24.24.mp4

Copy link
Collaborator

@sherenem sherenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@psinger psinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Only odd thing is that system is chosen as the default prompt column in dpo.
Could we change that?

@pascal-pfeiffer
Copy link
Collaborator Author

done
image

@pascal-pfeiffer pascal-pfeiffer merged commit 6020ee4 into main May 24, 2024
4 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the pp/improve_dataset_import branch May 24, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants