Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#8): char is LOWERCASE_LETTER #9

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat(#8): char is LOWERCASE_LETTER #9

merged 1 commit into from
Sep 24, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Sep 24, 2024

closes #8


PR-Codex overview

This PR focuses on modifications to the parsing rules in src/program.pest and src/parser/fsl_parser.rs, specifically adjusting the definitions for login and char, as well as updating test cases to reflect new valid and invalid inputs.

Detailed summary

  • In src/program.pest:
    • Changed -login to +login definition.
    • Updated -char to +char to only allow LOWERCASE_LETTER.
  • In src/parser/fsl_parser.rs:
    • Updated test cases to change valid input from "foo123" to "foo" and added invalid inputs "X" and "XYZ".
  • Removed comments regarding prohibiting upper-case letters in references.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 24, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1786466 into master Sep 24, 2024
11 checks passed
@rultor
Copy link
Collaborator

rultor commented Sep 24, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 42min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsl_parser.rs:127-129: Prohibit usage of upper-case...
3 participants