Skip to content

Commit

Permalink
mxc_hdmi: Dont require CEA mode
Browse files Browse the repository at this point in the history 
This fixes problems with DVI monitors connected to the HDMI port
via a DVI <-> HDMI cable. With dvi monitors, the list of CEA modes
is always zero, preventing modes higher than 1024x768 to be used.
This patch disables the CEA mode check.

Upstream-Status: Pending

Signed-off-by: Jeffrey Clark <[email protected]>
  • Loading branch information
@dv1
dv1 authored and Jeffrey Clark committed May 25, 2014
1 parent 9d567e4 commit 5174d6a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/video/mxc/mxc_hdmi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1800,10 +1800,10 @@ static void mxc_hdmi_edid_rebuild_modelist(struct mxc_hdmi *hdmi)
*/
mode = &hdmi->fbi->monspecs.modedb[i];

if (!(mode->vmode & FB_VMODE_INTERLACED) &&
(mxc_edid_mode_to_vic(mode) != 0)) {
if (!(mode->vmode & FB_VMODE_INTERLACED)) {
int vic = mxc_edid_mode_to_vic(mode);

dev_dbg(&hdmi->pdev->dev, "Added mode %d:", i);
dev_dbg(&hdmi->pdev->dev, "%s: Added mode %d(VIC %u):", __func__, i, vic);
dev_dbg(&hdmi->pdev->dev,
"xres = %d, yres = %d, freq = %d, vmode = %d, flag = %d\n",
hdmi->fbi->monspecs.modedb[i].xres,
Expand Down

3 comments on commit 5174d6a

@johnweber
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jeffrey -
Instead of this commit, what do you think of Boundary Devices' fixes here? This would allow a boot param in the KCL to turn off the check for CEA modes.

boundarydevices/linux@2e4b980

Thanks,
John

@h0tw1r3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing various monitors and televisions, my proposed patch is not a good solution. Your suggestion of using a boot param is OK, but I think there is a better solution of accepting DMT modes without overwriting built-in CEA modes.

I am testing some other patches and will submit a separate pull request in the future. I would like to provide a boot param that can force only CEA (current), DMT (BD's solution), or auto (combine both without overwriting CEA modes).

Similar to what Utiltie has done but with a boot param to disable the behavior.

@johnweber
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right - I can see that if they added the only_cea boot param check around the last chunk of code the splices the two lists together, then it would be the same as the stock code.

Please sign in to comment.