*: configurable 'etcd' binary log-output

Fix etcd-io#5449.

embed/config.go

@@ -111,9 +111,13 @@ type Config struct {
 
 	// debug
 
-	Debug        bool   `json:"debug"`
+	Debug       bool `json:"debug"`
+	EnablePprof bool
+
+	// log
+
 	LogPkgLevels string `json:"log-package-levels"`
-	EnablePprof  bool
+	LogOutput    string `json:"log-output"`
 
 	// ForceNewCluster starts a new cluster even if previously started; unsafe.
 	ForceNewCluster bool `json:"force-new-cluster"`

etcdmain/config.go

@@ -184,6 +184,7 @@ func newConfig() *config {
 	// logging
 	fs.BoolVar(&cfg.Debug, "debug", false, "Enable debug-level logging for etcd.")
 	fs.StringVar(&cfg.LogPkgLevels, "log-package-levels", "", "Specify a particular log level for each etcd package (eg: 'etcdmain=CRITICAL,etcdserver=DEBUG').")
+	fs.StringVar(&cfg.LogOutput, "log-output", "", "Specify 'stdout' or 'stderr' to skip journald logging even when running under init (ppid == 1).")
 
 	// unsafe
 	fs.BoolVar(&cfg.ForceNewCluster, "force-new-cluster", false, "Force to create a new one member cluster.")

etcdmain/etcd.go

@@ -392,6 +392,19 @@ func setupLogging(cfg *config) {
 		}
 		repoLog.SetLogLevel(settings)
 	}
+
+	// capnslog initially SetFormatter(NewDefaultFormatter(os.Stderr))
+	// where NewDefaultFormatter returns NewJournaldFormatter when syscall.Getppid() == 1
+	// specify 'stdout' or 'stderr' to skip journald logging even when running under init (ppid == 1)
+	switch cfg.LogOutput {
+	case "stdout":
+		capnslog.SetFormatter(capnslog.NewPrettyFormatter(os.Stdout, cfg.Debug))
+	case "stderr":
+		capnslog.SetFormatter(capnslog.NewPrettyFormatter(os.Stderr, cfg.Debug))
+	case "":
+	default:
+		plog.Panicf(`unknown log-output %q (only supports "", "stdout", "stderr")`, cfg.LogOutput)
+	}
 }
 
 func checkSupportArch() {

etcdmain/help.go

@@ -139,6 +139,8 @@ logging flags
 		enable debug-level logging for etcd.
 	--log-package-levels ''
 		specify a particular log level for each etcd package (eg: 'etcdmain=CRITICAL,etcdserver=DEBUG').
+	--log-output ''
+		specify 'stdout' or 'stderr' to skip journald logging even when running under init (ppid == 1).
 
 unsafe flags: