Fix wasm32-unknown-unknown support #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`XXH_STATIC_ASSERT` appears to already have a reasonable definition, and defining it to `0` breaks uses of it.
This was referenced Apr 19, 2024
jszwedko
added a commit
to vectordotdev/vector
that referenced
this pull request
Apr 24, 2024
To fix a WASM build issue. We can upgrade again once gyscos/zstd-rs#274 is merged and released (or gyscos/zstd-rs#271 is otherwise fixed). Also add a test that builds the playground to catch this sort of regression in the future. Signed-off-by: Jesse Szwedko <[email protected]>
github-merge-queue bot
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Apr 25, 2024
* chore(dev): Bump down zstd-sys from 2.0.10 to 2.0.9 To fix a WASM build issue. We can upgrade again once gyscos/zstd-rs#274 is merged and released (or gyscos/zstd-rs#271 is otherwise fixed). Also add a test that builds the playground to catch this sort of regression in the future. Signed-off-by: Jesse Szwedko <[email protected]> * Revert "chore(deps): Bump the zstd group with 1 update (#20199)" This reverts commit 0599d60. Signed-off-by: Jesse Szwedko <[email protected]> * chmod +x Signed-off-by: Jesse Szwedko <[email protected]> * Just put directly in env prepare Signed-off-by: Jesse Szwedko <[email protected]> * Bump timeout Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
|
I, unfortunately, have to bump this issue as well as pinning zstd-sys to |
|
Thanks for the work! The initial wasm32-unknown support was added in #139, I'm also not really sure why this definition was added. Let's merge this if this helps you! |
|
Thank you so much! Would you be able to publish a patch release for zstd-sys to crates.io / what’s your rough timeline until the next release? |
|
@gyscos ping Would you be able to publish a patch release for zstd-sys to crates.io that includes this change? |
AndrooTheChen
pushed a commit
to discord/vector
that referenced
this pull request
Sep 23, 2024
* chore(dev): Bump down zstd-sys from 2.0.10 to 2.0.9 To fix a WASM build issue. We can upgrade again once gyscos/zstd-rs#274 is merged and released (or gyscos/zstd-rs#271 is otherwise fixed). Also add a test that builds the playground to catch this sort of regression in the future. Signed-off-by: Jesse Szwedko <[email protected]> * Revert "chore(deps): Bump the zstd group with 1 update (vectordotdev#20199)" This reverts commit 0599d60. Signed-off-by: Jesse Szwedko <[email protected]> * chmod +x Signed-off-by: Jesse Szwedko <[email protected]> * Just put directly in env prepare Signed-off-by: Jesse Szwedko <[email protected]> * Bump timeout Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXH_STATIC_ASSERTappears to already have a reasonable definition, and defining it to0breaks uses of it.I'm not sure why that definition was added originally.
This also fixes the github action workflow to actually build the wasm target; previously it was just building the native target which allowed this issue to slip through.
Fixes #271.