Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention 3-clause BSD in zstd-safe/zstd-sys/LICENSE? #171

Closed
martinvonz opened this issue Oct 10, 2022 · 3 comments · Fixed by #173
Closed

Mention 3-clause BSD in zstd-safe/zstd-sys/LICENSE? #171

martinvonz opened this issue Oct 10, 2022 · 3 comments · Fixed by #173

Comments

@martinvonz
Copy link
Contributor

https://github.com/gyscos/zstd-rs/blob/master/zstd-safe/zstd-sys/src/bindings_zdict.rs includes the 3-clause BSD license, so doesn't that mean that it needs to be mentioned in zstd-sys's LICENSE file?

@martinvonz
Copy link
Contributor Author

I guess that applies to all of the generated bindings, actually.

@martinvonz
Copy link
Contributor Author

I can create a PR for that if it helps. I think licenses are usually concatenated (with some separator between) in the LICENSE file. Would you like the BSD license in the main LICENSE file or in a separate file?

@gyscos
Copy link
Owner

gyscos commented Oct 17, 2022

Hi!
Sorry, didn't get much time to look into that.

I can create a PR for that if it helps.

Absolutely! Thanks a lot :)

Would you like the BSD license in the main LICENSE file or in a separate file?

I think separate files would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants