Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support for python 3.13 #241

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ci: support for python 3.13 #241

wants to merge 5 commits into from

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Nov 5, 2024

Add formal support for python 3.13 in our CI

still to do:

  • remove support for py 3.8
  • check that changes to devcontainer still allow us to use bcftools and ART

@@ -45,6 +45,6 @@ echo "Location of trtools installation: $loc"
echo "Running pytest ..."
cd "$loc" || exit 1
# run unit tests
python -m pytest . -p trtools.testsupport.dataloader --datadir "$TMP"/trtools/testsupport
python -m pytest . --datadir "$TMP"/trtools/testsupport
Copy link
Member Author

@aryarm aryarm Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python -m pytest . --datadir "$TMP"/trtools/testsupport
python -m pytest . -p testsupport.dataloader --datadir "$TMP"/trtools/testsupport

I'm guessing this isn't working because $loc is already inside the trtools directory. Will need to check before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant