-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add longtr support #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
large-files
Warning Label for use when LFS is detected in the commits of a Pull Request
label
Aug 30, 2024
github-actions
bot
removed
the
large-files
Warning Label for use when LFS is detected in the commits of a Pull Request
label
Aug 30, 2024
heliziii
reviewed
Aug 31, 2024
heliziii
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Melissa, I went through your changes and all is good. Thank you.
heliziii
approved these changes
Sep 20, 2024
heliziii
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit support for LongTR VCF files, meaning most commands will now accept
--vcftype longtr
. Because LongTR is an extension of HipSTR for long reads, the format is very similar to HipSTR and some HipSTR functions are reused. The main difference is the stutter fields are not present.In fact, in most cases giving a LongTR VCF but specifying
--vcftype hipstr
should still work fine.Checklist
fix:
. Otherwise, if it introduces a new feature, please prefix it withfeat:
. If it introduces a breaking change, please add an exclamation before the colon, likefeat!:
. If the scope of the PR changes because of a revision to it, please update the PR title, since the title will be used in our CHANGELOG.poetry lock --no-update
to ensure the lock file stays up to date and that our dependencies are locked to their minimum versions