Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable filter_hrun with beagle file in dumpSTR #225

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Buuxx
Copy link
Contributor

@Buuxx Buuxx commented Aug 12, 2024

This PR enables Beagle imputed files to run with filter_hrun in dumpSTR.

Deleted the section in dumpSTR that checks is_beagle and filter_hrun. Updated the test case accordingly.

Checklist

  • I've checked to ensure there aren't already other open pull requests for the same update/change
  • I've prefixed the title of my PR according to the conventional commits specification. If your PR fixes a bug, please prefix the PR with fix: . Otherwise, if it introduces a new feature, please prefix it with feat: . If it introduces a breaking change, please add an exclamation before the colon, like feat!: . If the scope of the PR changes because of a revision to it, please update the PR title, since the title will be used in our CHANGELOG.
  • (NA) At the top of the PR, I've listed any open issues that this PR will resolve. For example, "resolves #0" if this PR resolves issue #0
  • I've explained my changes in a manner that will make it possible for both users and maintainers of TRTools to understand them
  • I've added tests for any new functionality. Or, if this PR fixes a bug, I've added test(s) that replicate it
  • (NA) All directories with large test files are listed in the "exclude" section of our pyproject.toml so that they do not appear in our PyPI distribution. All new files are also smaller than 0.5 MB.
  • (NA) I've updated the relevant REAMDEs with any new usage information and checked that the newly built documentation is formatted properly
  • (NA) All functions, modules, classes etc. still conform to numpy docstring standards
  • (if applicable) I've updated the pyproject.toml file with any changes I've made to TRTools's dependencies, and I've run poetry lock --no-update to ensure the lock file stays up to date and that our dependencies are locked to their minimum versions
  • In the body of this PR, I've included a short address to the reviewer highlighting one or two items that might deserve their focus

BEGIN_COMMIT_OVERRIDE
fix: enable filter_hrun with beagle file in dumpSTR
END_COMMIT_OVERRIDE

Copy link
Contributor

@gymreklab gymreklab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@gymreklab gymreklab merged commit be63e79 into master Aug 14, 2024
12 checks passed
@gymreklab gymreklab deleted the dumpSTR_delete_filterhrun_beagle_warning branch August 14, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants