build: remove Dockerfile, add codespace config, and bump min python #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to encourage vscode to use the trtools env
|
@aarushi03, can I request your review on this PR, since you've worked with GitHub codespaces before? Can you try out the new badge (checked out to the
|
Certainly. Reviewing it now. |
aarushi03
requested changes
Dec 16, 2023
aryarm
commented
Dec 16, 2023
aryarm
changed the title
aarushi03
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our now-defunct Dockerfile. Instead, we recommend that you use the TRTools image maintained by the Bioconda team on the biocontainers registry. The docs have been updated to reflect this.
To offset the removal of the Dockerfile, this PR adds an alternative way to work with TRTools in the cloud: GitHub codepsaces! This can be helpful when you want to quickly play around with our code but don't want to go through all of the setup steps. Just click on the "Open in Github Codespaces" badge on the README and voila - you'll be presented with a VS Code environment automagically set up with TRTools and our development dependencies. This environment will run with (usually free-for-academic-use) credits on Github's codespace VMs.
Finally, this PR also specifies a strategy for our support for various python versions. From now on, we will only formally support active versions of python that are not end-of-life (3.8+). However, at least for now, we think that TRTools will still run properly for versions 3.6 and 3.7 - although support for those versions is not guaranteed and may break at any time.