-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: migrate from setup.py to pyproject.toml and set up CI #193
Conversation
since setup.py will be deprecated
the option was specific to alabaster but we changed to rtd in #179
@LiterallyUniqueLogin, can I ask you for approval for this, too? it should also help to fix the failing build issues in @aarushi03's PR (#191) |
ERROR trtools/testsupport/sample_vcfs/associaTR/generate_traits.py - FileNotFoundError: [Errno 2] No such file or directory: 'samples.txt'
ERROR trtools/testsupport/sample_vcfs/associaTR/make_dosages.py - OSError: Error opening many_samples_biallelic.vcf.gz
@LiterallyUniqueLogin, it looks like the tests are failing because
Are those tools necessary for the associaTR tests? If so, I could try to install them in the CI environment. |
b/c setuptools-scm doesn't support automated versioning for py 3.7 The version_file option was added as support for py3.7 was dropped: https://github.com/pypa/setuptools_scm/releases/tag/v8.0.0
since this happens when someone does "pip install ." instead of "pip install -e ." (ie the editable version) pypa/setuptools-scm#357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall! I haven't tested that any of the changes work as described, I've just read through the docs. Just a few minor comments.
Thank you for all the work to keep this package maintained!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good. One last change: I'd remove the mention of using the web interface to create tags under the section "git tagging" (and then also remove the mention that there are two ways). Reason being that it seems this process requires the tag to exist locally so that python -m build
uses that tag, and the web interface wouldn't meet that requirement, right?
Actually, if they use the web interface, the tag should still exist locally as long as they do a |
...since setup.py is obsolete (source)
we also migrate from travis CI and code-cov to github actions according to these directions. This will allow us to integrate testing into the PR approval process
Note: We still don't have a lock file or any version constraints in our pyproject.toml, so our CI is still prone to death whenever a breaking change to one of our dependencies is uploaded to PyPI. If we want to tackle that, it can be a future-me problem 😅
note: this pr also fixes some issues arising from deprecations in the readthedocs config (source) and resolves all warning messages in the current readthedocs build. In order to get the tests to pass, I also had to make some small alterations to the code