Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete requirements.txt. #166

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Delete requirements.txt. #166

merged 2 commits into from
Aug 22, 2022

Conversation

LiterallyUniqueLogin
Copy link
Contributor

Also Clarify bioconda build process in PUBLISHING.rst

aryarm
aryarm approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@aryarm aryarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, @LiterallyUniqueLogin ! I don't see any problems with the tweaked workflow

This might be out of the scope of this PR, but one thing I noticed is that PUBLISHING.rst doesn't have any instructions on how to build the documentation locally, which might help people iterate and preview changes to the docs faster. Might be something to consider for a future PR or something.

PUBLISHING.rst Outdated Show resolved Hide resolved
PUBLISHING.rst Outdated Show resolved Hide resolved
@LiterallyUniqueLogin @aryarm
Apply suggestions from code review
fbabeee 
Grammar fixes

Co-authored-by: Arya Massarat <[email protected]>
@LiterallyUniqueLogin
Copy link
Contributor Author

looks good, @LiterallyUniqueLogin ! I don't see any problems with the tweaked workflow

This might be out of the scope of this PR, but one thing I noticed is that PUBLISHING.rst doesn't have any instructions on how to build the documentation locally, which might help people iterate and preview changes to the docs faster. Might be something to consider for a future PR or something.

That info is in the contributing section of the README . If you have a spot you think it should go in PUBLISHING also, let me know and I'm happy to add it there.

@aryarm
Copy link
Member

aryarm commented Aug 22, 2022

ah, I see it now! ok, looks great

no, I don't think it needs to also be in PUBLISHING in that case

@LiterallyUniqueLogin LiterallyUniqueLogin merged commit 31525cc into develop Aug 22, 2022
@LiterallyUniqueLogin LiterallyUniqueLogin deleted the delete_requirements branch August 22, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryarm aryarm aryarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiterallyUniqueLogin @aryarm