fix the minimum position bug in mergeutils #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yang_mergestr_bug
|
Hi Yang, I ran the pytests and trtools/mergeSTR/tests/test_mergeSTR.py::test_GangSTRRightFile is failing. Can you fix that? (Or confirm that it's an issue with how I'm running it). Also, you put a random 'G' into the .gitignore file which I think wasn't intended. |
|
Hi Jonathan, Thanks for reviewing the code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetIncrementAndComparability function in mergeutils.py gives error message "stuck in infinite loop and exiting error". The error is caused by the min_pos may get from STRs on different chromosomes when samples have different called STRs. Therefore generate an increment list with all FALSE values. Fix it by get the min_pos from the chromosome== min_chrom_index only