Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requestAllItems using the odata.nextlink #4

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

KarelBrijs
Copy link
Contributor

This PR adds the ability to retrieve all items in a folder using the odata.nextlink that is being passed whenever there are more pages in the result set due to the standard limitation of 200 results per request. This PR will still work even after a suffix such as '$top=300' is passed to the request.

Copy link
Contributor

@jnovermars jnovermars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, A small remark the function requestAllItems should not be exposed outside of the class so i will make it private (unless you have a good reason not)

@jnovermars jnovermars merged commit 2c9e528 into gwsn:main Oct 5, 2023
@jnovermars jnovermars added the enhancement New feature or request label Oct 5, 2023
@jnovermars jnovermars self-assigned this Oct 5, 2023
@KarelBrijs
Copy link
Contributor Author

@jnovermars I missed that one, thanks, also for merging quickly, if anything else let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants