Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omicron column in the hdf5 format #37

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

iaraota
Copy link

@iaraota iaraota commented Jun 11, 2024

This PR updates the omicron column names to be compatible with the HDF5 format. This is needed to make VET compatible with the new version of GWSumm, which uses HDF5 format as default.

Omicron will soon drop support for the XML format, see here.

Closes #36.

@eagoetz eagoetz self-requested a review June 11, 2024 17:47
gwvet/etg.py Show resolved Hide resolved
Copy link
Collaborator

@eagoetz eagoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eagoetz eagoetz added this to the 1.0.1 milestone Jun 12, 2024
@eagoetz eagoetz merged commit 9f08a33 into gwpy:master Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VET Failing
2 participants