Bump gwbootstrap version #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 49.64% 49.64%
=======================================
Files 60 60
Lines 8823 8823
=======================================
Hits 4380 4380
Misses 4443 4443
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
iaraota
approved these changes
Mar 27, 2024
|
@eagoetz thank you for working on this. Does this update requires |
eagoetz
force-pushed
the
bump-gwbootstrap
branch
from
8361bb3 to
d2096a5
Compare
|
Ah, and now the tests fail. Let me check it out |
|
@iaraota All checks now pass. I think it was an issue that gwdetchar-2.2.4 was not available on conda-forge (because I had not merged the update into the feedstock) but it is there now, so the build passes. I will merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gwbootstrap to the latest version to handle fancybox API changes