Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Axes.grid keyword to use 'visible' #383

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Oct 31, 2023

This PR updates the Axes.grid keyword arguments to use visible that is needed because of upstream matplotlib updates.

This PR replaces #368

@eagoetz eagoetz self-assigned this Oct 31, 2023
@eagoetz eagoetz added this to the 2.2.0 milestone Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #383 (f5d3cde) into master (b5559a4) will not change coverage.
The diff coverage is 9.09%.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   50.17%   50.17%           
=======================================
  Files          60       60           
  Lines        8685     8685           
=======================================
  Hits         4357     4357           
  Misses       4328     4328           
Flag Coverage Δ
Linux 50.17% <9.09%> (ø)
python3.10 50.17% <9.09%> (ø)
python3.11 50.17% <9.09%> (ø)
python3.9 50.17% <9.09%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gwsumm/plot/core.py 84.18% <0.00%> (ø)
gwsumm/plot/triggers/core.py 17.82% <0.00%> (ø)
gwsumm/plot/noisebudget.py 20.49% <0.00%> (ø)
gwsumm/plot/segments.py 21.89% <0.00%> (ø)
gwsumm/plot/builtin.py 21.72% <20.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eagoetz
Copy link
Collaborator Author

eagoetz commented Nov 1, 2023

@iaraota I have double-checked that using visible=True or visible=False works fine using matplotlib>=3.5

setup.cfg Outdated Show resolved Hide resolved
This PR updates the Axes.grid keyword arguments to use visible that is needed because of upstream matplotlib updates.

This PR replaces gwpy#368
@eagoetz eagoetz merged commit a50504f into gwpy:master Nov 1, 2023
9 of 10 checks passed
@eagoetz eagoetz deleted the update-grid branch November 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants