-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #5
Open
duboism
wants to merge
12
commits into
main
Choose a base branch
from
add_CI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are copied from https://github.com/gw-odw/odw-2023 and barely adapted
This allows to use the same logic in a git pre-commit hook.
This allows to use the same logic in a git pre-commit hook. The action has to be split between notebooks and other files.
This allows to use the same logic in a git pre-commit hook.
As before, the logic is in a separate script.
CI will run on PR, pushes on main and on-demand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CI rules. This is done to enforce some of the contributions guidelines. This partially addresses #4.
The rules are strongly inspired by the ones created by Gregory Ashton for ODW 2023. To acknowledge that, a file listing contributions was added (see
Contributors.md
).What is checked?
The followings items are checked:
When are the rules applied?
The rules are applied when pushing on the
main
branch or before merging PR. They can also be run on-demand.