Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Greatly improved forms with dbt profile browsing #8

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

gwenwindflower
Copy link
Owner

This PR greatly improves the forms that compose the TUI, based on feedback from the dbt Labs DX team.

  • Now unified into one form with conditional visibility rather than multiple forms with conditional logic
    • This allows shift+tab and tab to back/forward through the entire thing
  • Validated input to prevent entering blank values
  • Default values where sensible so you can Just Hit Enter
  • We fetch all the dbt profiles before the form runs, so you can browse them rather than trying to enter the name correctly, this will error early if there are parsing issues with the profiles rather than after you fill out the form

Leveraged deeper understanding of huh form library to combine all the forms into one, with conditional visibility based on previous answers. Added ability to browse dbt profiles rather than trying to recall the name. Added more explicit error handling when we can't parse the dbt profile.
@gwenwindflower gwenwindflower merged commit ccfd7ba into main Apr 20, 2024
1 check passed
@gwenwindflower gwenwindflower deleted the feat/browse-profiles-in-form branch April 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant