Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Ecc bank with phenom ecc waveform #50

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

bhooshan-gadre
Copy link

Stocastic eccentric bank:

  • Here is a working code for ecc stochastic bank for Phenom ecc approximant.
  • I have marked WIP as the approximant is not available and cannot be tested with the current lalsuite.
  • Also, there is a possibility of getting rough metric matches to improve the bank generation. Maybe that will be a separate PR?

@bhooshan-gadre bhooshan-gadre marked this pull request as draft September 29, 2022 14:00
@spxiwh
Copy link
Collaborator

spxiwh commented Sep 29, 2022

THanks @bhooshan-gadre . Skimming over this, it definitely looks like there's a number of different changes in here (e.g. including XAS should be separated from any eccentric stuff, there's a lal file pulled into here, the rough metric matches). Can these be pulled off for ease of review? (Also we would have to wait for the eccentric waveform to be in a lal release before we can really include it here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants