Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jncep update constantly updates the same part #28

Closed
jzkmath opened this issue Oct 4, 2022 · 5 comments
Closed

jncep update constantly updates the same part #28

jzkmath opened this issue Oct 4, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@jzkmath
Copy link

jzkmath commented Oct 4, 2022

Describe the bug
So this is probably an edge case but whenever I run jncep update the series "Realist Hero" always updates despite the latest part already updated. This is probably because j-novel club released a crossover story and it is listed as volume 18. So basically volume 17 has 11 out of 12 parts out then there is 1 part for "volume 18". I suspect that the unreleased part 12 is causing this issue.

Expected behavior
the update command shouldn't update a part that was already updated.

To Reproduce
run jncep update while tracking realist hero. Every time you run this command it will update volume 17 part 11. I expect this bug will disappear as soon as the last prepub part is released (this thursday i think)

Debug trace
N/A

Environment:

  • OS: Ubuntu 22.04
  • Python version: 3.10.36
  • JNCEP version: v38 (latest version as of writing report)
@jzkmath jzkmath added the bug Something isn't working label Oct 4, 2022
@gvellut
Copy link
Owner

gvellut commented Oct 4, 2022

OK I will have a look. jncep uses the release dates (to deal with the case you mention...) instead of the part numbers.

Could you send me your track.json file? It should be inside the ~/.jncep folder.

@gvellut
Copy link
Owner

gvellut commented Oct 4, 2022

Actually, no need for your track.json. I can reproduce the issue even if I just subscribed to the series.

@gvellut gvellut closed this as completed in 92a9d03 Oct 4, 2022
@gvellut
Copy link
Owner

gvellut commented Oct 4, 2022

I have made a correction. I will make a new release soon.

@jzkmath
Copy link
Author

jzkmath commented Oct 11, 2022 via email

@gvellut
Copy link
Owner

gvellut commented Oct 11, 2022

This is because the date of the last part (in number, so the date of 18.1 in this case) is recorded instead of the last date (ie date of 17.11) : The date of 18.1 is before the date of 17.11, hence the issue.

But your message made me think: I forgot to apply the correction I did for the update (from your original issue) to the track add command (so the date of the last part is recorded). I will have to make another release for that...

@gvellut gvellut reopened this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants