Disallow TAGSTRING_START after the conversion character in an f-string #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, although this does make the code more complicated. It's already quite hard to follow what's going on -- I was mostly "programming by random modification" in the tag-strings-v2 branch. |
|
That's true. Maybe it isn't worth it? Either way, one of the thing on my to-do list is to start adding comments to the different parts of the tokenizer, where the logic may be hard to follow, like we discussed at PyCon. |
M485631
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this, just so you know what I meant in jimbaker/tagstr#22 (comment) and because I'll be on a plane the whole day tomorrow.
This PR solves 3/5 failures in
test_fstringwith the other two being related to what I wrote in jimbaker/tagstr#22 (comment).