Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove magic trimming of URI component delimiters #83

Merged
merged 3 commits into from
May 18, 2016
Merged

remove magic trimming of URI component delimiters #83

merged 3 commits into from
May 18, 2016

Conversation

Tobion
Copy link
Member

@Tobion Tobion commented May 10, 2016 •
edited
Loading

This PR is based on #81 and will be rebased when #81 is merged.

  • unify wrong type handling for uri components: withHost didn't check the type for example, but withPath did. And withQuery checked for __toString which is not specified in PSR-7.
  • remove magic trimming of component delimiters which is not according to PSR-7. This magic has been removed in [PSR-7] UriInterface: rootless path, delimiters, consistency php-fig/fig-standards#503
  • add missing lowercase normalization for host
  • improve encoding tests
  • use possessive quantifier to encode uri (++) to prevent regex backtracking which improves performance

@mtdowling
Copy link
Member

The other PR is merged. Can you rebase?

@Tobion
Copy link
Member Author

Tobion commented May 11, 2016

Done

@Tobion
Copy link
Member Author

Tobion commented May 18, 2016

@mtdowling ping

@mtdowling mtdowling merged commit 99606eb into guzzle:master May 18, 2016
@Tobion Tobion deleted the uri-delimiters branch May 18, 2016 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobion @mtdowling