Use Sphinx.set_translator #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to always register the `HTMLTranslator` instead of informing users to add the translator to their configuration files. The `html_translator_class` config option was recently deprecated, so now seems a good time to switch.
|
Looks good, thanks! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this Sphinx theme, it looks beautiful.
I tried it with the most recent version of Sphinx and got a deprecation warning on account of the use of the
html_translator_classconfig option. The recommended way to do this now is to call theset_translatormethod on the Sphinx app, so this PR does that. I believe this method is available in any version of Sphinx >= 1.3, but since the current requirements had < 1.3 I assumed there was an issue with that release and so set the required version to be > 1.3.