fix: Unsupported listener protocol type error for nil supportKinds as…

…sign gateway status. (envoyproxy#4345)
guydc · Sep 27, 2024 · 7babca9 · 7babca9
1 parent 14830c7
commit 7babca9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/internal/gatewayapi/listener.go b/internal/gatewayapi/listener.go
@@ -74,6 +74,7 @@ func (t *Translator) ProcessListeners(gateways []*GatewayContext, xdsIR resource
 			case gwapiv1.UDPProtocolType:
 				t.validateAllowedRoutes(listener, resource.KindUDPRoute)
 			default:
+				listener.SetSupportedKinds(gwapiv1.RouteGroupKind{Kind: "InvalidKind"})
 				status.SetGatewayListenerStatusCondition(listener.gateway.Gateway,
 					listener.listenerStatusIdx,
 					gwapiv1.ListenerConditionAccepted,

diff --git a/internal/gatewayapi/testdata/gateway-with-listener-with-unsupported-protocol.out.yaml b/internal/gatewayapi/testdata/gateway-with-listener-with-unsupported-protocol.out.yaml
@@ -34,7 +34,8 @@ gateways:
         status: "True"
         type: ResolvedRefs
       name: unsupported
-      supportedKinds: null
+      supportedKinds:
+      - kind: InvalidKind
 httpRoutes:
 - apiVersion: gateway.networking.k8s.io/v1
   kind: HTTPRoute