'Support both csso v1 and v2' - Improved code in handling csso optimization function (justDoIt vs. minify) #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csso
releases review:Tested with:
0.1.8
as a base.1.3.12
,1.4.0
,1.8.0
,2.0.0
and latest (checked 2017/02/18)2.3.1
.2.1.10
and2.3.2
6.9.5
+ npm3.10.10
7.5.2
+ npm4.1.2
r.js -o example/build.js
with all possible values foroptimizeCss
Compatibility Note: I realize, this change may be overthinking/overcomplex, but so far the fact is - there are end consumers of
require-css
who will upgrade to newrequire-css
version, but remain oldcsso
version--global
or as in my enterprise case (locally in project).They will have errors like I mentioned in this PR and in #203 and #219.
A bit of automation :) in this boring life
compatibility-test.sh
.optimizeCss
inexample/build.js
file from"none"
tooptimizeCss: "standard.keepLines"
optimizeCss: "standard.keepWhitespace"
optimizeCss: "standard.keepComments"
optimizeCss: "standard.keepComments.keepLines"
optimizeCss: "standard.keepLines.keepWhitespace"
- default byr.js
compatibility.log
. By searching valueCompressed CSS output
in that log file, u should see always all good, no Syntax Errors. Active for Feb-19-2017.cc/ @guybedford @prantlf