Support Module Source Worker Instantiation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would only check at the last minute. This would be buggy in the case where we create a new navigable, and then throw an exception. Instead we should be sure to throw before creating a new navigable. In addition to fixing this somewhat-obviously-wrong bug, this also causes validation to happen before popup blocking or other window-choosing steps. Previously, if trying to open a window to an unparseable URL with the popup blocker active, the window open steps would return null; now, they throw an exception. Closes whatwg#10681.
This includes two related changes: 1. The showPopover() and togglePopover() methods now include an options bag that allows setting the popover source. 2. Popover sources (declaratively or imperatively set) now create an implicit anchor reference for that popover. See discussion in whatwg#9144 (comment). Closes whatwg#10442. Closes whatwg#10675.
Cause noopener to be set for window.open(), clicks on <a> / <area> elements, and form submissions where the corresponding blob URL is cross-site to the top-level site of the context performing the action. This corresponds to the discussion in w3c/FileAPI#153.
guybedford
force-pushed
the
esm-source-phase
branch
from
28b5a43
to
5dd1fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft HTML PR spec text to verify the cross-specification interactions of the ESM Source Phase proposal, specifying:
new Worker(moduleSource)for both JS and Wasm module sources, based on the newHostGetModuleSourceModuleRecordhost hook andGetModuleSourceModuleRecordconcrete method.import(moduleSource)based on the updatedHostLoadImportedModuleAPI, with full registry key coalescing based on module source equivalence via the newModuleSourcesEqualconcrete method.postMessage(moduleSource)based on supported structured serialize and deserialize for JSModuleSourceobjects (while this remains defined for Wasm in https://www.w3.org/TR/wasm-web-api-2/, but yet to be updated to support the ESM Phase Imports proposal in turn.This is based to the latest version of ESM Phase Imports (https://tc39.es/proposal-esm-phase-imports/).
The WebAssembly ESM Integration updates to these APIs are not currently included here but should be landed along with this in due course to:
[[ModuleRecord]]slot on WebAssembly.Module objects to enableHostGetModuleRecordFromSourceHostGetModuleRecordFromSourcethat populates this object from the Wasm side when needed (ie when previously compiled modules get passed to source functions such asimport()ornew Worker()Finally, the main HTML questions here are around the security properties of source cloning and worker construction. A half-backed
rooted sourceproperty is implemented for module scripts to distinguish between "checked URL sources" and evalish sources, but this needs to still be turned into a proper model further. In addition shared workers and worklets are not currently supported but could be additions to this spec.