feat: still polyfill when early module loads stop import maps #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
early-module-load
branch
from
bca301e
to
51da6b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way of working around the issue in WICG/import-maps#248.
Instead of simply having the application not work in polyfill mode when there is eg a browser extension on the page injecting a module script before the import map, this will do a detection to see if there are any module scripts before the import maps, and if so kick into the polyfill mode automatically.
In addition this adds a new hook option
onpolyfillthat can be used to check when the polyfill is engaging. When passed via the JSON<script type="esms-options">{ ... }</script>the string value is taken to be the global function name of the hook to call.