Switch to using asyncio.timeout instead of asyncio.wait_for #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`asyncio.wait_for` creates a task whereas `asyncio.timeout` avoids doing this. Fallback to using `async_timeout` when the python version is too old (<3.11) `asyncio.timeout` will become the underlying implementation for `async.wait_for` in cpython 3.12 python/cpython#98518
bdraco
commented
Mar 7, 2023
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.wait_forcreates a task whereasasyncio.timeoutavoids doing this which decreases latency.Fallback to using
async_timeoutwhen the python version is too old (<3.11)asyncio.timeoutwill become the underlying implementation forasync.wait_forin cpython 3.12 python/cpython#98518