Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for pyrogram v2 #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qqwbarta
Copy link

@qqwbarta qqwbarta commented Jan 26, 2024

fixes #67

@qqwbarta qqwbarta marked this pull request as ready for review January 26, 2024 16:25
@mxkmn
Copy link

mxkmn commented Feb 1, 2024

Thank you, it works, but you also need to update version in requirements.txt

@qqwbarta
Copy link
Author

qqwbarta commented Feb 1, 2024

I might be wrong but one downside of this version is that now it only deletes messages, previously it deleted all the reactions and group events like entering the group, leaving and so on

@gurland
Copy link
Owner

gurland commented Jun 26, 2024

@qqwbarta Thank you for your contribution! I think this PR is a great starter to migrate the project to the newest version of Pyrogram.

Didn't even know that the scipt was able to remove reactions. However, we have to preserve functional backward compatibility, so that all reactions are deleted as well.

We should also think on performance impact meaning that using new high-level Pyrogram APIs we may need to send additional requests to retract reactions using send_reaction method

@lbgracioso
Copy link

Thank you! It worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msg_id is too low error
4 participants