Fix graph height calculation for small value ranges #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request addresses an issue where graphs with small value ranges (less than 1) were not being displayed correctly, often resulting in a flat line at 0.00. This will resolve the issue #56.
The problem was caused by the height calculation rounding down to 0 for small intervals, which led to division by zero errors in subsequent calculations. This was also suggested by @palash25 in the comments of the issue, thanks.
Changes made to resolve the issue:
calculateHeight()
.The solution maintains consistency in height calculation across different scales of data, so graphs with ranges like {0.2, 0.3, 0.1} will have a similar appearance to graphs with ranges like {2, 3, 1}.
Also, refactored a bit related to the conflicting name of variables with built-in methods.