feat(deps): update deps, support of eslint 8 #38

Delagen · 2021-10-12T13:22:05Z

Not sure if it correct, but who doesn't make errors?

codeclimate

The PR diff size of 26847 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 26883 lines exceeds the maximum allowed for the inline comments feature.

d-arrington · 2021-10-12T17:29:06Z

For what it's worth, I pulled your branch into my current project and it seems to be working as intended.

bfaulk96

LGTM

crystalfp · 2021-10-13T12:24:50Z

Please merge! It is the last eslint plugin that does not work under eslint 8. Thanks!

paulius-valiunas · 2021-10-13T15:06:18Z

I know this is not even merged yet, but what's the release schedule here? Can we expect this change to be part of a release in the following days?

bfaulk96 · 2021-10-13T15:09:33Z

Well considering there hasn't been a release for this in 5 months... I wouldn't count on it happening too quickly haha

paulius-valiunas · 2021-10-13T15:15:28Z

I mean it's understandable since there haven't been any merged PRs since May. Last time there was a PR that was merged, a new patch version was pushed out on the same day. If only there was a way to get @gund's attention... 😊

bfaulk96 · 2021-10-18T19:10:07Z

@gund It's totally understandable that you are probably quite busy, but is there any chance you'd be open to people being added as maintainers so that this project isn't left untouched for long periods of time?

jdom · 2021-11-01T17:40:52Z

+1 I'm currently blocked from updating eslint due to this plugin, which blocks us from updating @typescript-eslint packages, which blocks us from updating typescript itself now (as TypeScript 4.4 isn't supported by older eslint packages)!
EDIT: I misjudged, I was able to update the @typescript-eslint packages to version 5.2, and that didn't require updating eslint to version 8 (I was at least able to update to 7.32, not sure if that's required).

bfaulk96 · 2021-11-01T21:23:14Z

Kind of sounds like it might be time for us to ask npm to declare it up for adoption and fork it? Since none of the contributors seem to be active or responsive 🙁
Or we could just fork it and publish it as eslint-plugin-deprecations (with an s) 😅

jleider · 2021-11-08T18:56:14Z

While we are waiting for these things to be merged I created a quick and dirty release with this change and #33.

Just add the following to your package.json:

"eslint-plugin-deprecation": "https://github.com/jleider/eslint-plugin-deprecation#v1.3.0"

codeclimate

The PR diff size of 26961 lines exceeds the maximum allowed for the inline comments feature.

Delagen · 2021-11-09T12:45:35Z

Published as @delagen/eslint-plugin-deprecation, also included #35

lachieh · 2021-11-09T13:09:38Z

Rather than continuing to fork and publish new versions, perhaps the typescript-eslint team would be interested in bringing in this rule.

@JamesHenry is there a process for this sort of thing? Is that something the typescript-eslint team would do?

Thread TL;DR:
This rule doesn't yet support Eslint 8 and the maintainer @gund has been radio silent for the last 6 months.

jdom · 2021-11-09T13:13:59Z

I updated my previous comment, looks like I'm no longer blocked.

I misjudged, I was able to update the @typescript-eslint packages to version 5.2, and that didn't require updating eslint to version 8 (I was at least able to update to 7.32, not sure if that's required).

Having said that disclaimer, I'd still like the package to support to support eslint 8, so that we can move forward. Alternatively, it would be awesome to have this rule officially supported by the TypeScript team as @lachieh suggested

crystalfp · 2021-11-09T13:16:39Z

Thanks a lot @Delagen for your work!
I need just an update on how to use the updated plugin.

Installed with npm i -D @delagen/eslint-plugin-deprecation
In eslint.yaml added - "@delagen/eslint-plugin-deprecation" under plugins
Under rules: I tried:
- "@delagen/eslint-plugin-deprecation: warn"
- "@delagen/eslint-plugin-deprecation/deprecation: warn"
- deprecation/deprecation: warn (as was before)

But always eslint responds with Definition for rule 'deprecation' was not found (deprecation)

Could you help me?

Delagen · 2021-11-09T13:40:08Z

@crystalfp just installed it to try to investigate problem. Seems Eslint support for namespaced plugins is tweaky

Delagen · 2021-11-09T13:44:51Z

@crystalfp Seems working

plugins:[
"@delagen/deprecation"
],
rules:{
"@delagen/deprecation/deprecation": "warn"
}

What version of ESLINT are you using?

crystalfp · 2021-11-09T14:02:19Z

With your suggestion it works! Now I have to think of a deprecation just to test.
I'm using eslint 8.0.0
Thanks!
mario

timgates42 · 2021-12-02T19:59:35Z

package.json

@@ -1,12 +1,18 @@
 {
-  "name": "eslint-plugin-deprecation",
-  "version": "0.0.0-development",
+  "name": "@delagen/eslint-plugin-deprecation",


Looks like some of the changes include in this file might not have been intended for the upstream update?

This is because of fork. I updated this project in master branch

@timgates42 if you has permission to merge and publish npm, I can rebase this Mr

truncated into #39

lachieh · 2021-12-03T03:44:09Z

It looks like there has been an issue open for a while to add a deprecation rule into the typescript-eslint project.

That same issue references another issue that talks about one of three options:

If someone wants to port the rule to an independent eslint plugin, feel free!
If someone wants to simply document how to use the sonar rule, they can do that instead.
If someone wants to independently implement the rule based on tslint's implementation, they can do that too.

Originally posted by @bradzacher in typescript-eslint/typescript-eslint#1223 (comment)

It looks like @gund went down the first route, but given the lack of activity, it might be about time to take a look at implementing the third (implementing a rule based on the tslint implemention).

I'll likely have a look at this path over the weekend, but if anyone else wants to take a look, feel free.

bfaulk96 · 2021-12-03T20:11:30Z

@lachieh It's worth noting that while I fully agree this would be great to have in typescript-eslint, @Delagen forked this plugin and fixed the problems (for option 1), but the issue now is that this plugin is taking up dead space in npm.

snebjorn · 2021-12-06T14:44:00Z

tsconfig.json

+    "importHelpers": true,
+    "sourceMap": true,
+    "module": "CommonJS",
+    "target": "ES2015",


Not sure if relevant but the change from ES5 to ES2015 is a breaking change :)

ES5 is not ES2015. ES2015 is ES6.

If you see supported versions of node.js by eslint, I think it can be even higher

You're right. I just saw the target change and figured I'd point it out :)

But given that ESLint 8 only supports "node": "^12.22.0 || ^14.17.0 || >=16.0.0" then I guess it's safe to use ES2019
https://node.green/#ES2019

codeclimate

The PR diff size of 26977 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 27134 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 27164 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2021-12-09T20:27:29Z

Code Climate has analyzed commit 1893daf and detected 0 issues on this pull request.

View more on Code Climate.

gund · 2021-12-14T15:25:33Z

Hey folks, this has been resolved in #39!

fix: print deprecation reason correctly on ts 4.3+

98b24c1

Delagen force-pushed the master branch from 1cfc3a8 to 384e311 Compare October 12, 2021 13:31

codeclimate bot reviewed Oct 12, 2021

View reviewed changes

feat(deps): update deps, support of eslint 8

6cb798c

Delagen force-pushed the master branch from 384e311 to 6cb798c Compare October 12, 2021 13:33

codeclimate bot reviewed Oct 12, 2021

View reviewed changes

d-arrington mentioned this pull request Oct 12, 2021

Does not work with ESLint v8 #37

Closed

bfaulk96 approved these changes Oct 12, 2021

View reviewed changes

mlegenhausen mentioned this pull request Oct 13, 2021

Upgrade to eslint 8 werk85/eslint-config-werk85#25

Closed

4 tasks

alumni mentioned this pull request Oct 18, 2021

False positive in definition after update to typescript-eslint v5 #36

Closed

This was referenced Nov 8, 2021

[Fix] Handle array-based tag.text #33

Closed

jsdoc/tsdoc not parsed correctly #29

Closed

Delagen added 2 commits November 9, 2021 15:19

Merge remote-tracking branch 'gluxon/typescript-4.3-compat'

0c6da47

fix(deps): update deps and fix compilation

65c69a4

codeclimate bot reviewed Nov 9, 2021

View reviewed changes

1.3.0

481df7d

jenssimon mentioned this pull request Nov 11, 2021

eslint-plugin-deprecation ESLint 8 compatibility jenssimon/eslint-config-typescript#3

Closed

internalsystemerror mentioned this pull request Nov 19, 2021

Angular 13 support ng-bootstrap/ng-bootstrap#4178

Closed

6 tasks

timgates42 reviewed Dec 2, 2021

View reviewed changes

fix(package): remove dist definition

45756fa

snebjorn reviewed Dec 6, 2021

View reviewed changes

codeclimate bot reviewed Dec 9, 2021

View reviewed changes

fix(package): revert mr, 1.3.2 release

1893daf

Delagen force-pushed the master branch from 2abbb0a to 1893daf Compare December 9, 2021 20:27

codeclimate bot reviewed Dec 9, 2021

View reviewed changes

gund closed this Dec 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(deps): update deps, support of eslint 8 #38

feat(deps): update deps, support of eslint 8 #38

Delagen commented Oct 12, 2021 •

edited

Loading

codeclimate bot left a comment

codeclimate bot left a comment

d-arrington commented Oct 12, 2021

bfaulk96 left a comment

crystalfp commented Oct 13, 2021

paulius-valiunas commented Oct 13, 2021

bfaulk96 commented Oct 13, 2021

paulius-valiunas commented Oct 13, 2021

bfaulk96 commented Oct 18, 2021

jdom commented Nov 1, 2021 •

edited

Loading

bfaulk96 commented Nov 1, 2021 •

edited

Loading

jleider commented Nov 8, 2021

codeclimate bot left a comment

Delagen commented Nov 9, 2021

lachieh commented Nov 9, 2021

jdom commented Nov 9, 2021

crystalfp commented Nov 9, 2021

Delagen commented Nov 9, 2021 •

edited

Loading

Delagen commented Nov 9, 2021

crystalfp commented Nov 9, 2021

timgates42 Dec 2, 2021

Delagen Dec 2, 2021

Delagen Dec 2, 2021

Delagen Dec 3, 2021

lachieh commented Dec 3, 2021

bfaulk96 commented Dec 3, 2021

snebjorn Dec 6, 2021

Delagen Dec 6, 2021

snebjorn Dec 6, 2021

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot commented Dec 9, 2021

gund commented Dec 14, 2021

feat(deps): update deps, support of eslint 8 #38

feat(deps): update deps, support of eslint 8 #38

Conversation

Delagen commented Oct 12, 2021 • edited Loading

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

d-arrington commented Oct 12, 2021

bfaulk96 left a comment

Choose a reason for hiding this comment

crystalfp commented Oct 13, 2021

paulius-valiunas commented Oct 13, 2021

bfaulk96 commented Oct 13, 2021

paulius-valiunas commented Oct 13, 2021

bfaulk96 commented Oct 18, 2021

jdom commented Nov 1, 2021 • edited Loading

bfaulk96 commented Nov 1, 2021 • edited Loading

jleider commented Nov 8, 2021

codeclimate bot left a comment

Choose a reason for hiding this comment

Delagen commented Nov 9, 2021

lachieh commented Nov 9, 2021

jdom commented Nov 9, 2021

crystalfp commented Nov 9, 2021

Delagen commented Nov 9, 2021 • edited Loading

Delagen commented Nov 9, 2021

crystalfp commented Nov 9, 2021

timgates42 Dec 2, 2021

Choose a reason for hiding this comment

Delagen Dec 2, 2021

Choose a reason for hiding this comment

Delagen Dec 2, 2021

Choose a reason for hiding this comment

Delagen Dec 3, 2021

Choose a reason for hiding this comment

lachieh commented Dec 3, 2021

bfaulk96 commented Dec 3, 2021

snebjorn Dec 6, 2021

Choose a reason for hiding this comment

Delagen Dec 6, 2021

Choose a reason for hiding this comment

snebjorn Dec 6, 2021

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Dec 9, 2021

gund commented Dec 14, 2021

Delagen commented Oct 12, 2021 •

edited

Loading

jdom commented Nov 1, 2021 •

edited

Loading

bfaulk96 commented Nov 1, 2021 •

edited

Loading

Delagen commented Nov 9, 2021 •

edited

Loading