-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional argument isDeep to File.clone #29
Conversation
c0
commented
Aug 7, 2014
- Allows passing in isDeep:false to perform a shallow clone.
- Allows passing in isDeep:false to perform a shallow clone.
To put this in context, I left |
@c0 Wow 15s to clone a file? That seems insane. We might have other problems if that's the case - we may want to look at using a new method of cloning that's closer to the metal |
I think it's necessary to set this argument. One for performance, the other some customObj don't want to be deep cloned
|
Fixed by #32 |