Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Marshall old Vinyl objects to new Version in dest() #291

Merged
merged 3 commits into from
Dec 28, 2017

Conversation

phated
Copy link
Member

@phated phated commented Dec 22, 2017

@erikkemperman @asgoth @stevelacy @doowb What do y'all think of this as the solution to #288 and gulpjs/gulp/issues/2065

@doowb
Copy link
Member

doowb commented Dec 22, 2017

@phated LGTM! I like that a new Vinyl instance is created only when an old Vinyl instance is detected.

@erikkemperman
Copy link
Member

Not sure if we call isSymbolic() there, but if so should this be done for symlink and even src as well? And perhaps add a comment that this is to deal with out-of-date plugins and hopefully could be removed at some point?

@stephenlacy
Copy link

I do also agree with @erikkemperman relating to also check/modify symlink. The rest looks good

@phated
Copy link
Member Author

phated commented Dec 26, 2017

@erikkemperman @stevelacy I've added the marshalling to .symlink but I don't think it's necessary because we don't check .isSymbolic() in that API - (.src actually always marshalls in the wrap-file stream). I've also added erik's requested TODO.

@erikkemperman
Copy link
Member

@phated Looks good to me, thanks!

@phated phated merged commit bbfb50c into master Dec 28, 2017
@phated phated deleted the marshall-old-vinyl branch December 28, 2017 00:36
@phated
Copy link
Member Author

phated commented Dec 28, 2017

@erikkemperman @doowb @stevelacy Thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants