Read-contents/index, invoke cb with error or result, not both #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @erikkemperman |
|
@erikkemperman There seems to have been a race condition with node 0.10 on this change. Not sure why but I re-ran and it passed. |
|
@phated That's weird -- I don't see how this little change would do that... Do you have logs so I can take a peek? I've run the test suite a couple of times with 0.10.0 and 0.10.48 but haven't been able to reproduce it here (Linux). |
|
Doesn't look like travis gives me access to the old logs of a restarted job. It was something with a file descriptor being undefined when we expected it to be defined. I'll keep an eye out in the future. |
erikkemperman
added a commit
to erikkemperman/vinyl-fs
that referenced
this pull request
Oct 4, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate PR, as per @phated's comment on #257.