Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .cjs file extension #60

Closed
wants to merge 3 commits into from
Closed

Add support for .cjs file extension #60

wants to merge 3 commits into from

Conversation

cedx
Copy link

@cedx cedx commented Oct 28, 2019

Should fix #59

@cedx
Copy link
Author

cedx commented Oct 28, 2019

Hmmm... the tests fail but I don't understand the root cause (i.e. rechoir tries to find a module loader despite that interpret asserts that there is no loader).

Manually creating a gulpfile.cjs and running gulp works as expected locally (at least with my Node.js version, which is v13.0.1).

@cedx
Copy link
Author

cedx commented Jan 14, 2020

I close this PR because it is not needed anymore: see solution provided in #59.

@cedx cedx closed this Jan 14, 2020
@cedx cedx mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add support for the .cjs file extension
1 participant
@cedx