-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theming #137
Theming #137
Conversation
Fix windows tests
this should solve all of the wack installation issues we were seeing on windows machines, and work correctly with io.js. - v8flags is now async - v8flags caches flags at first run, not on installation - liftoff `nodeFlags` was renamed to `v8flags` for accuracy
bump liftoff and v8flags
@phated Sorry, I don't really have an opinion on this... Well, not an opinion that you don't already know, anyway :-) Having said that, it's probably just a typo above but is it |
This pr makes clear coloring and easy to add a function of configuring colors. However some names are ambiguous, e.g. About |
@sttk good points. I was actually trying to add some more work onto this but ran into a problem because we register the logger more than once and need to clean it up. I'm starting to think the config-file stuff shouldn't be within liftoff but instead should be within the |
I've created a package: ansi-colors-nestable and ansi-colors-prioritized to extend ansi-colors. Are these usable? To this pr, I tried to suggest about help message, such as: var usage = `\n' +
color.helpUsage('Usage:') + ' '
color.helpSyntax('gulp ' + color.helpOptions('[options]') + ' tasks'); but ansi-color doesn't support nesting, and ansi-colors-nestable enables this as follows: var nestableColor = require('ansi-colors-nestable');
color.helpSyntax = nestableColor('(color-name)');
var usage = `\n' +
color.helpUsage('Usage:') + ' '
color.helpSyntax('gulp ', color.helpOptions('[options]'), ' tasks'); Another one, ansi-colors-prioritized enables to set multiple colors with priority.
|
@sttk those are some interesting modules, but my thoughts are converging on using template strings Something like: var usage = '\n{helpUsage}Usage:{/helpUsage} {helpSyntax}gulp {helpOptions}[options]{/helpOptions} tasks{/helpSyntax}' But I'm not happy with that verbosity and I'd like to solve argument replacement as well so we don't have to use string concatenation (probably using printf-style variables like |
@sttk @erikkemperman @tdeschryver I've begun experimenting with a solution to chalk replacement that utilizes yargs to parse
--color
/--no-color
and replaces direct color names to work towards #63There's still some problems with this approach so I may use @tdeschryver's solution of checking the process.argv directly for
--no-colors
I just wanted to open this to get some more eyes on it.