-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need more tests #2
Comments
Anyone willing to write some tests for the CLI? I'd like to have some more before 1.0 (which is coming very soon) |
Noticed that currently the tests for |
@erikkemperman I think that the gulp dep should actually just be installed through a travis matrix instead of having it as a devDep (this is in response to an error someone got with npm 3 about installing gulp as a dependency of gulp). Thoughts? |
Not on Travis matrices, unfamiliar. I have this working But I might have been cheating with symlinks. |
@phated Your remark about NPM3, was that basically as reported in #7? If I read that correctly, it has been fixed upstream? Above patch works for me, using stock NPM (2.14.4, from Anyway, whatever resolution is found eventually on inter-dependencies between gulp and gulp-cli, I can't imagine the current state of affairs (gulp-cli#4.0 depending on gulp3 for its testst) to be right... |
I'd be willing to contribute some tests but I'm not sure what functionality you'd want testing specifically. If you'd like to give me a hit-list I'm happy to tackle it. |
@Romanx we need unit tests on all of the functions in the |
@phated we consider this done or should we work on running 3.8+ and 4.0+ side by side in this ticket? |
@Romanx going to leave this open as something that any one can jump into and create some tests for. I think we are in a good place to release the 1.0 of gulp-cli with your tests added. |
@phated I wrote some unit test codes for However, they are written in my own way. Are there an unified way and a location rule for unit test codes? |
We have something like 95% code coverage now. I don't think this broad "make more tests" issue is needed anymore. We can identify missing tests and create individual issues for them. |
We need more exec tests.
The text was updated successfully, but these errors were encountered: