Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more tests #2

Closed
phated opened this issue Dec 28, 2014 · 12 comments
Closed

Need more tests #2

phated opened this issue Dec 28, 2014 · 12 comments

Comments

@phated
Copy link
Member

phated commented Dec 28, 2014

We need more exec tests.

@phated
Copy link
Member Author

phated commented Aug 21, 2015

Anyone willing to write some tests for the CLI? I'd like to have some more before 1.0 (which is coming very soon)

@erikkemperman
Copy link
Member

Noticed that currently the tests for gulp-cli#4.0 use a dev dependency on gulp>=3.8.10
Looks like an artifact from 0.3.0? Shouldn't that be gulpjs/gulp#4.0 or something?

@phated
Copy link
Member Author

phated commented Oct 16, 2015

@erikkemperman I think that the gulp dep should actually just be installed through a travis matrix instead of having it as a devDep (this is in response to an error someone got with npm 3 about installing gulp as a dependency of gulp). Thoughts?

@erikkemperman
Copy link
Member

Not on Travis matrices, unfamiliar.

I have this working
erikkemperman@ccad332

But I might have been cheating with symlinks.

@erikkemperman
Copy link
Member

@phated Your remark about NPM3, was that basically as reported in #7? If I read that correctly, it has been fixed upstream?

Above patch works for me, using stock NPM (2.14.4, from make install against latest node sources). But I have cross-linked my local gulp#4.0 and gulp-cli#4.0 before doing npm install and npm test on those.

Anyway, whatever resolution is found eventually on inter-dependencies between gulp and gulp-cli, I can't imagine the current state of affairs (gulp-cli#4.0 depending on gulp3 for its testst) to be right...

@Romanx
Copy link
Contributor

Romanx commented Oct 18, 2015

I'd be willing to contribute some tests but I'm not sure what functionality you'd want testing specifically. If you'd like to give me a hit-list I'm happy to tackle it.

@phated
Copy link
Member Author

phated commented Oct 19, 2015

@Romanx we need unit tests on all of the functions in the lib/ directory and we can use integration tests on all the CLI options (listed in the readme of 4.0 branch).

phated added a commit that referenced this issue Nov 9, 2015
@Romanx
Copy link
Contributor

Romanx commented Nov 10, 2015

@phated we consider this done or should we work on running 3.8+ and 4.0+ side by side in this ticket?

@phated
Copy link
Member Author

phated commented Nov 10, 2015

@Romanx going to leave this open as something that any one can jump into and create some tests for. I think we are in a good place to release the 1.0 of gulp-cli with your tests added.

@sttk
Copy link
Contributor

sttk commented Dec 30, 2015

@phated I wrote some unit test codes for logTasks, for PR #50. They are placed in my repository.

However, they are written in my own way. Are there an unified way and a location rule for unit test codes?

@phated
Copy link
Member Author

phated commented Jan 6, 2017

We have proper code coverage now (thanks to @sttk in #99!) so needed tests should be easier to identify. 😃

@phated
Copy link
Member Author

phated commented Mar 26, 2019

We have something like 95% code coverage now. I don't think this broad "make more tests" issue is needed anymore. We can identify missing tests and create individual issues for them.

@phated phated closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants