fix: Only traverse directories that can match the glob base #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffynuts
added a commit
to fluffynuts/gulp-streamify
that referenced
this pull request
Apr 8, 2024
(apparently resolved in gulpjs/glob-stream#131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the walking logic to take into account the base of each glob instead of walking only the
cwd. This allows globs that use an absolute path outside of thecwdor move gulpfiles into different directories (which causes theprocess.cwd()to be changed). We also need to only check the existence of a file against a singular glob. Both of these changes drastically speed up many cases of globbing.Fixes #127
Fixes #129
Fixes #130
I still need to look into #128 because the issue isn't clear on what paths don't work, as the only error seems to indicate an absolute path outside of the cwd.