Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api pull_request build failed due to head/head/ duplication #35

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

guitarrapc
Copy link
Owner

@guitarrapc guitarrapc commented Nov 11, 2022

tl;dr;

fixed: #34

TODO

  • detect CIRCLE_BRANCH contains /head, then remove /head.
  • Add Test Case for issue

@guitarrapc
Copy link
Owner Author

How can I reproduce failed test?

@guitarrapc guitarrapc self-assigned this Nov 11, 2022
@guitarrapc guitarrapc added the help wanted Extra attention is needed label Nov 11, 2022
Now pull_request flow is as same as checkout
@guitarrapc
Copy link
Owner Author

Now I can reproduce issue with https://github.com/guitarrapc/git-shallow-clone-test

@guitarrapc guitarrapc marked this pull request as ready for review November 28, 2022 16:37
@guitarrapc guitarrapc added bug Something isn't working and removed help wanted Extra attention is needed labels Nov 28, 2022
@guitarrapc guitarrapc merged commit c6ffe14 into main Nov 28, 2022
@guitarrapc guitarrapc deleted the feature/fix_api_pr branch November 28, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shallow cloning fails when running on pull request
1 participant