fix tests and checkstyle

guipmenezes · Nov 4, 2023 · a13e3c8 · a13e3c8
1 parent 798d723
commit a13e3c8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/org/jabref/gui/fieldeditors/ISSNEditor.java b/src/main/java/org/jabref/gui/fieldeditors/ISSNEditor.java
@@ -83,6 +83,7 @@ public void requestFocus() {
     private void fetchInformationByIdentifier() {
         entry.ifPresent(viewModel::fetchBibliographyInformation);
     }
+
     @FXML
     private void showJournalInfo() {
         if (JournalInfoOptInDialogHelper.isJournalInfoEnabled(dialogService, preferencesService.getEntryEditorPreferences())) {

diff --git a/src/main/java/org/jabref/logic/importer/fetcher/IssnFetcher.java b/src/main/java/org/jabref/logic/importer/fetcher/IssnFetcher.java
@@ -30,7 +30,7 @@ public List<BibEntry> performSearch(BibEntry entry) throws FetcherException {
         Optional<String> issn = entry.getField(StandardField.ISSN);
         if (issn.isPresent()) {
             Optional<JournalInformation> journalInformation = journalInformationFetcher.getJournalInformation(issn.get(), "");
-            return journalInformation.map(journalInfo -> journalInformationToBibEntry(journalInfo, issn.get()) ).stream().toList();
+            return journalInformation.map(journalInfo -> journalInformationToBibEntry(journalInfo, issn.get())).stream().toList();
         }
         return Collections.emptyList();
     }
@@ -46,7 +46,7 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
         return journalInformation.map(journalInfo -> journalInformationToBibEntry(journalInfo, identifier));
     }
 
-    private BibEntry journalInformationToBibEntry(JournalInformation journalInfo, String issn){
+    private BibEntry journalInformationToBibEntry(JournalInformation journalInfo, String issn) {
         return new BibEntry().withField(StandardField.JOURNALTITLE, journalInfo.title()).withField(StandardField.PUBLISHER, journalInfo.publisher()).withField(StandardField.ISSN, issn);
     }
 }
diff --git a/src/main/java/org/jabref/logic/integrity/ISSNChecker.java b/src/main/java/org/jabref/logic/integrity/ISSNChecker.java
@@ -25,6 +25,6 @@ public Optional<String> checkValue(String value) {
         if (!issn.isValidChecksum()) {
             return Optional.of(Localization.lang("incorrect control digit"));
         }
-        return Optional.of(issnString);
+        return Optional.empty();
     }
 }
diff --git a/src/test/java/org/jabref/logic/importer/fetcher/IssnFetcherTest.java b/src/test/java/org/jabref/logic/importer/fetcher/IssnFetcherTest.java
@@ -22,6 +22,7 @@ class IssnFetcherTest {
 
     private IssnFetcher fetcher;
     private BibEntry bibEntry;
+
     @BeforeEach
     void setUp() {
         ImportFormatPreferences importPrefs = mock(ImportFormatPreferences.class);
@@ -41,6 +42,7 @@ void performSearchByEntry() throws FetcherException {
         List<BibEntry> fetchedEntry = fetcher.performSearch(bibEntry);
         assertEquals(List.of(bibEntry), fetchedEntry);
     }
+
     @Test
     void performSearchById() throws FetcherException {
         Optional<BibEntry> fetchedEntry = fetcher.performSearchById("15454509");